Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fetching chain id #2506

Merged
merged 3 commits into from
Oct 17, 2024
Merged

Bug fetching chain id #2506

merged 3 commits into from
Oct 17, 2024

Conversation

sophialittlejohn
Copy link
Collaborator

Description

This pull request...

  • fixes a bug loading the pool overview page where chainId is incorrectly references from provider

#

Approvals

  • Dev

Screenshots

Impact

Copy link

github-actions bot commented Oct 17, 2024

PR deployed in Google Cloud
URL: https://app-pr2506.k-f.dev
Commit #: 95a35cc
To access the functions directly check the corresponding deploy Action

Copy link

github-actions bot commented Oct 17, 2024

PR deployed in Google Cloud
URL: https://pr2506-app-ff-production.k-f.dev
Commit #: 95a35cc
To access the functions directly check the corresponding deploy Action

@@ -40,12 +41,20 @@ export function InvestRedeemLiquidityPoolsProvider({ poolId, trancheId, children
isLoading: isInvestmentLoading,
} = useLiquidityPoolInvestment(poolId, trancheId, lpIndex)
const provider = useEvmProvider()
const [chainId, setChainId] = React.useState(1)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const [chainId, setChainId] = React.useState(1)
const { evm: { chainId } } = useWallet()

@sophialittlejohn sophialittlejohn enabled auto-merge (squash) October 17, 2024 15:38
@sophialittlejohn sophialittlejohn merged commit 727d4c3 into main Oct 17, 2024
11 checks passed
@sophialittlejohn sophialittlejohn deleted the fix-ethersjs-bugs branch October 17, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants